giscience issueshttps://gitlab.gistools.geog.uni-heidelberg.de/groups/giscience/-/issues2024-03-25T11:44:20Zhttps://gitlab.gistools.geog.uni-heidelberg.de/giscience/disaster-tools/fbf-sudan/-/issues/8Improve column filtering in pre-processing or add warning2024-03-25T11:44:20ZTill FrankenbachImprove column filtering in pre-processing or add warningColumns that don't start with "ADM" ("AMD" for instance) do not get filtered/removed during data pre-processing. They then may interfere with further processing such as `utils.normalize_indicators`.Columns that don't start with "ADM" ("AMD" for instance) do not get filtered/removed during data pre-processing. They then may interfere with further processing such as `utils.normalize_indicators`.https://gitlab.gistools.geog.uni-heidelberg.de/giscience/disaster-tools/fbf-sudan/-/issues/7Welthungerhilfe (WHH) RA Madagascar and Zimbabwe2024-02-12T12:57:46ZAlec Schulze-EckelWelthungerhilfe (WHH) RA Madagascar and ZimbabweThe WHH tried to use the plugin for RAs in two countries and received the traceback below
I had a look at the data for Madagascar and there a certainly issues. I cleaned the data and received the same traceback.
I did not have a look a...The WHH tried to use the plugin for RAs in two countries and received the traceback below
I had a look at the data for Madagascar and there a certainly issues. I cleaned the data and received the same traceback.
I did not have a look at the Zimbabwe data.
Could someone check what is the issue?
You can find the data __[here](https://nexus.heigit.org/repository/gis-training-resource-center/Risk_Assessment/WHH_data.zip)__.
![WHH_RA_Traceback](/uploads/67e1ae16358d00c22a9d911399554c1c/WHH_RA_Traceback.png)Anne SchaussAnne Schausshttps://gitlab.gistools.geog.uni-heidelberg.de/giscience/disaster-tools/fbf-sudan/-/issues/4Add documentation2023-12-01T13:01:13ZJakob SchnellAdd documentationCurrently, there is no documentation at all.
There's a few ways we could go here:
1. Add a link to the `.docx`-documentation that is currently being written
2. Add a help file that shows up on the right (compare ORSTools or similar).
3...Currently, there is no documentation at all.
There's a few ways we could go here:
1. Add a link to the `.docx`-documentation that is currently being written
2. Add a help file that shows up on the right (compare ORSTools or similar).
3. Add a description to the different parameters (compare QuickOSM or the like).
We could do all, we could do some, but we probably shouldn't have no documentation at all…https://gitlab.gistools.geog.uni-heidelberg.de/giscience/disaster-tools/fbf-sudan/-/issues/3Drop `pandas` dependency2024-03-25T11:22:20ZJakob SchnellDrop `pandas` dependencyCurrently, we are using `pandas`, converting the csv data into dataframes and processing them.
QGIS natively supports csv, table calculations and the like. We should make use of that.
https://anitagraser.com/pyqgis-101-introduction-to-...Currently, we are using `pandas`, converting the csv data into dataframes and processing them.
QGIS natively supports csv, table calculations and the like. We should make use of that.
https://anitagraser.com/pyqgis-101-introduction-to-qgis-python-programming-for-non-programmers/pyqgis-101-using-expressions-to-compute-new-field-values/ might have some valuable knowledge :)https://gitlab.gistools.geog.uni-heidelberg.de/giscience/disaster-tools/fbf-sudan/-/issues/1Follow recommendations for QGIS plugins2023-11-17T09:48:00ZJakob SchnellFollow recommendations for QGIS pluginshttps://plugins.qgis.org/publish/ lists a lot of recommendations. I think, we don't strictly follow the following:
#### Requirements
* Plugins need to have at least minimal documentation - we currently have none. See #4
* The plugin m...https://plugins.qgis.org/publish/ lists a lot of recommendations. I think, we don't strictly follow the following:
#### Requirements
* Plugins need to have at least minimal documentation - we currently have none. See #4
* The plugin metadata contains a link to the source code, an issue tracker and a license - it does, but it's not publicly available
* The plugin license is compatible with the [GPLv2 or later](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) ([more information about licensing](http://blog.qgis.org/2016/05/29/licensing-requirements-for-qgis-plugins/)) - we don't have a license
* If the plugin has an external dependency, this needs to be clearly stated in the About metadata field - we should document the pandas dependency, or drop it. See #3
**Recommendations**
* Provide a minimal data set for testing - we currently don't test at all
* Put the plugin into the appropriate menu (Vector, Raster, Web, Database) - I don't know which one that is. I assume `Vector`.
* Before publishing a new plugin, check if it duplicates existing functionality and explore collaboration possibilities - I don't think anyone does this, but again, I don't know
* Check if source code uploaded to the QGIS plugin repo as zip is identical to "Code repository" indicated in metadata.txt - it is sort of, we still have a few remnants of the plugin builder
* Mention any requirements, dependencies and restrictions in the description text section (which can be multi-line). Examples of requirements, dependencies and restrictions are, if the plugin is running only on selected platforms, requires SW to be installed separately or some user account, but also if the plugin is spatially covering just some countries or regions. - as above
**Tips and Tricks**
* Keep your source repository in good shape:
* No generated files left in the repository (ui\_\*.py, resources_rc.py, gen. help files…). - I'm not sure about this
* Good code organization (subfolders). - I don't think this is complicated enough for anything
* PEP8 & Python/QGIS guidelines compliance. - haven't checked them
* A README file and a LICENCE file are present. - they aren't, but code isn't public yet…
* If some dependencies are not available in OSGeo4w Python, provide instructions on how to install them on Windows. - That should be for s/o to checkhttps://gitlab.gistools.geog.uni-heidelberg.de/giscience/ideal-vgi/osm-element-vectorisation/-/issues/109Central Notes Database does not get updated since 20212023-07-24T09:07:22ZMoritz SchottCentral Notes Database does not get updated since 2021If we continue to use this tool, we have to update the database because all our past calculation where wrong with regards to Notes. But this is currently not planned so this issue is on hold.If we continue to use this tool, we have to update the database because all our past calculation where wrong with regards to Notes. But this is currently not planned so this issue is on hold.Johannes VisintiniJohannes Visintinihttps://gitlab.gistools.geog.uni-heidelberg.de/giscience/deleted_map/-/issues/8Create a reverted-map2023-06-07T17:13:42ZMoritz SchottCreate a reverted-mapIdea Source: https://www.openstreetmap.org/user/pitscheplatsch/diary/401668
Idea:
1. search for all changesets that mention the word "revert"
2. filter all elements that have been touched by these changesets
3. use the code here: https...Idea Source: https://www.openstreetmap.org/user/pitscheplatsch/diary/401668
Idea:
1. search for all changesets that mention the word "revert"
2. filter all elements that have been touched by these changesets
3. use the code here: https://github.com/GIScience/oshdb/issues/507 to extract all elements that have experienced a revert in their state before and after the revert
4. create a new tab on the deleted map that only shows theses elements in two different layers (may need adjustement depending on how the data looks like)https://gitlab.gistools.geog.uni-heidelberg.de/giscience/deleted_map/-/issues/7Add Mumbai2023-06-07T17:08:27ZMoritz SchottAdd Mumbaihttps://twitter.com/mrizwan1khan/status/1418151941767667712
/cc @rkhanhttps://twitter.com/mrizwan1khan/status/1418151941767667712
/cc @rkhanhttps://gitlab.gistools.geog.uni-heidelberg.de/giscience/ideal-vgi/osm-element-vectorisation/-/issues/108Remove creation from list of edits for edits_per_year parameter2023-05-02T17:43:28ZMoritz SchottRemove creation from list of edits for edits_per_year parameterhttps://gitlab.gistools.geog.uni-heidelberg.de/giscience/ideal-vgi/osm-element-vectorisation/-/issues/106Make a coherent design choise for prcision vs. speed2023-03-27T13:23:48ZMoritz SchottMake a coherent design choise for prcision vs. speedThe tool sometimes makes less accurate compuations (e.g. user diversity -> only for the object creator) in favour of processing time. But this is not always the case (e.g. OQT requests are made at maximum precision, which is slow).
The...The tool sometimes makes less accurate compuations (e.g. user diversity -> only for the object creator) in favour of processing time. But this is not always the case (e.g. OQT requests are made at maximum precision, which is slow).
There should be a coherent design choice.https://gitlab.gistools.geog.uni-heidelberg.de/giscience/ideal-vgi/osm-element-vectorisation/-/issues/105Frontend overcharged with big examples2023-07-12T14:50:43ZMoritz SchottFrontend overcharged with big examplesThere is to much data, should we replace it with a subselection?There is to much data, should we replace it with a subselection?https://gitlab.gistools.geog.uni-heidelberg.de/giscience/ideal-vgi/osm-element-vectorisation/-/issues/104Folksonomy not working for key=* tags (e.g. in lines example)2023-03-17T21:58:32ZMoritz SchottFolksonomy not working for key=* tags (e.g. in lines example)https://gitlab.gistools.geog.uni-heidelberg.de/giscience/ideal-vgi/osm-element-vectorisation/-/issues/103Frontend - Overview stats for indicators2023-03-03T07:26:24ZSven LautenbachFrontend - Overview stats for indicatorsFor future versions of the frontend it would be a nice to have feature to present for each indicator summary statistics (mean, std, quantiles) instead of (or maybe in combination with) the color based highlighting of elements in/out of t...For future versions of the frontend it would be a nice to have feature to present for each indicator summary statistics (mean, std, quantiles) instead of (or maybe in combination with) the color based highlighting of elements in/out of the q25-q75 rangehttps://gitlab.gistools.geog.uni-heidelberg.de/giscience/big-data/ohsome/ml-models/building-completeness-model/-/issues/4Evaluate trained model2023-03-01T12:01:58ZMatthias SchaubEvaluate trained model- [ ] Blocker #3- [ ] Blocker #3https://gitlab.gistools.geog.uni-heidelberg.de/giscience/big-data/ohsome/ml-models/building-completeness-model/-/issues/3Train model (global extent)2023-03-01T12:01:24ZMatthias SchaubTrain model (global extent)- [ ] Blocker: #1 #2- [ ] Blocker: #1 #2https://gitlab.gistools.geog.uni-heidelberg.de/giscience/ideal-vgi/osm-element-vectorisation/-/issues/102update shapely to 2.02023-02-22T15:06:44ZMoritz Schottupdate shapely to 2.0ohsome-py currently requires geopandas 0.9.0 which does not support shapely 2.0 (see https://github.com/GIScience/ohsome-py/issues/101)ohsome-py currently requires geopandas 0.9.0 which does not support shapely 2.0 (see https://github.com/GIScience/ohsome-py/issues/101)https://gitlab.gistools.geog.uni-heidelberg.de/giscience/ideal-vgi/osm-element-vectorisation/-/issues/99export fails if rpy is not installed2023-02-14T18:44:04ZMoritz Schottexport fails if rpy is not installed```
Traceback (most recent call last):
File "/...```
Traceback (most recent call last):
File "/home/mschott/.cache/pypoetry/virtualenvs/osm-element-vectorisation-xti8G22H-py3.8/lib/python3.8/site-packages/pandas/io/sql.py", line 2019, in execute
cur.execute(*args, **kwargs)
psycopg2.errors.UndefinedTable: relation "repex.osm_data_indicators_norm" does not exist
LINE 4: "repex"."osm_data_indicators_norm";
^
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/home/mschott/Dokumente/IDEAL-VGI/git-repos/osm-element-vectorisation_gitlab/src/osm_element_vectorisation/vectorisation.py", line 145, in vectorise_cli
exit_code = vectorise(settings)
File "/home/mschott/Dokumente/IDEAL-VGI/git-repos/osm-element-vectorisation_gitlab/src/osm_element_vectorisation/vectorisation.py", line 102, in vectorise
export(ac_settings)
File "/home/mschott/Dokumente/IDEAL-VGI/git-repos/osm-element-vectorisation_gitlab/src/osm_element_vectorisation/export/export.py", line 27, in export
_export_indicators(settings)
File "/home/mschott/Dokumente/IDEAL-VGI/git-repos/osm-element-vectorisation_gitlab/src/osm_element_vectorisation/export/export.py", line 55, in _export_indicators
indicators_df, indicators_norm_df = _get_indicators(settings)
File "/home/mschott/Dokumente/IDEAL-VGI/git-repos/osm-element-vectorisation_gitlab/src/osm_element_vectorisation/export/export.py", line 48, in _get_indicators
indicators_norm_df = settings.db_conns.get_db_pandas(
File "/home/mschott/Dokumente/IDEAL-VGI/git-repos/osm-element-vectorisation_gitlab/src/osm_element_vectorisation/settings/backend/database.py", line 124, in get_db_pandas
res = pandas.read_sql(fquery, conn, params=params, index_col=index_col)
File "/home/mschott/.cache/pypoetry/virtualenvs/osm-element-vectorisation-xti8G22H-py3.8/lib/python3.8/site-packages/pandas/io/sql.py", line 565, in read_sql
return pandas_sql.read_query(
File "/home/mschott/.cache/pypoetry/virtualenvs/osm-element-vectorisation-xti8G22H-py3.8/lib/python3.8/site-packages/pandas/io/sql.py", line 2079, in read_query
cursor = self.execute(*args)
File "/home/mschott/.cache/pypoetry/virtualenvs/osm-element-vectorisation-xti8G22H-py3.8/lib/python3.8/site-packages/pandas/io/sql.py", line 2031, in execute
raise ex from exc
pandas.errors.DatabaseError: Execution failed on sql 'Composed([SQL('SELECT\n *\nFROM\n '), Identifier('repex', 'osm_data_indicators_norm'), SQL(';\n')])': relation "repex.osm_data_indicators_norm" does not exist
LINE 4: "repex"."osm_data_indicators_norm";
```https://gitlab.gistools.geog.uni-heidelberg.de/giscience/deleted_map/-/issues/4Duplicate elements2022-11-30T08:18:44ZMoritz SchottDuplicate elementsCurrent process can/does extract duplicate entries because each region is requested separatelyCurrent process can/does extract duplicate entries because each region is requested separatelyhttps://gitlab.gistools.geog.uni-heidelberg.de/giscience/deleted_map/-/issues/3Polygons fail for Brazil2022-11-30T08:17:50ZMoritz SchottPolygons fail for Brazilsee https://github.com/GIScience/oshdb/issues/483see https://github.com/GIScience/oshdb/issues/483https://gitlab.gistools.geog.uni-heidelberg.de/giscience/deleted_map/-/issues/2Map ALL deleted objects2022-11-21T19:52:32ZMoritz SchottMap ALL deleted objectsMap deleted objects that are not seen on the default style as red elements. The attribute `osm_carto_display` is meant for that, but needs more coding.Map deleted objects that are not seen on the default style as red elements. The attribute `osm_carto_display` is meant for that, but needs more coding.